[fixed] Request for a shorthand addHighLevelShader for GL

You discovered a bug in the engine, and you are sure that it is not a problem of your code? Just post it in here. Please read the bug posting guidelines first.

[fixed] Request for a shorthand addHighLevelShader for GL

Postby hendu » Mon Dec 12, 2011 2:22 pm

GLSL functions are always named "main", and have no need for the DX version param. This currently means having two unneeded parameters in the addHighLevelShader call per shader type (vert, frag, geom - up to 6 unnecessary params).

It would be more elegant not to require those params - to have two (one for vert+frag, one for v+f+g) shorthand function wrappers in Irrlicht.


This is somewhat easier to work around client-side than the float* int* cast, but still this would be an improvement in the API :)
Last edited by hendu on Wed Jan 04, 2012 2:19 pm, edited 1 time in total.
hendu
 
Posts: 1933
Joined: Sat Dec 18, 2010 12:53 pm

Re: Request for a shorthand addHighLevelShader for GL

Postby hendu » Thu Dec 15, 2011 11:13 am

Ping. I'm willing to post patches, but please give me a yea/nay :)
hendu
 
Posts: 1933
Joined: Sat Dec 18, 2010 12:53 pm

Re: Request for a shorthand addHighLevelShader for GL

Postby CuteAlien » Thu Dec 15, 2011 11:30 am

*sigh* we really need someone again in the team who cares mainly about Shaders... it does not seem like BlindSide will come back. I can say unfortunately nothing at all about it, never coded a Shader myself, so have to leave this for now to Hybrid.
IRC: #irrlicht on irc.freenode.net
My Irrlicht code snippets: https://code.google.com/p/irr-playground-micha/
My patches&stuff: http://www.michaelzeilfelder.de/irrlicht.htm
Play a fun racer created with Irrlicht: http://www.irrgheist.com/
User avatar
CuteAlien
Admin
 
Posts: 6039
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany

Re: Request for a shorthand addHighLevelShader for GL

Postby hybrid » Thu Dec 15, 2011 1:06 pm

Yes, that's ok. I even have some patches for similar things. Please send in a patch for this one.
hybrid
Admin
 
Posts: 14089
Joined: Wed Apr 19, 2006 9:20 pm
Location: Oldenburg(Oldb), Germany

Re: Request for a shorthand addHighLevelShader for GL

Postby hendu » Thu Dec 15, 2011 4:16 pm

hendu
 
Posts: 1933
Joined: Sat Dec 18, 2010 12:53 pm

Re: Request for a shorthand addHighLevelShader for GL

Postby hendu » Mon Jan 02, 2012 3:38 pm

Ping as the holidays are over.
hendu
 
Posts: 1933
Joined: Sat Dec 18, 2010 12:53 pm


Return to Bug reports

Who is online

Users browsing this forum: No registered users and 0 guests