[fixed]GLES branch - missed a case in COGLESDriver.c

You discovered a bug in the engine, and you are sure that it is not a problem of your code? Just post it in here. Please read the bug posting guidelines first.
Post Reply
cheqnk
Posts: 5
Joined: Tue Feb 02, 2016 10:03 am

[fixed]GLES branch - missed a case in COGLESDriver.c

Post by cheqnk »

Hello Irrlicht.

I'd like to report a (looks like) bug on GLES branch.
It seems like you are missing a line for D24S8 color format case in COGLESDriver.c line 3155

Code: Select all

             os::Printer::log("ECF_D32 color format is not supported", ELL_ERROR);
        break;
#ifdef GL_OES_packed_depth_stencil
        if (queryOpenGLFeature(COGLES1ExtensionHandler::IRR_OES_packed_depth_stencil))
        {
            internalFormat = GL_DEPTH24_STENCIL8_OES;
            pixelFormat = GL_DEPTH_STENCIL_OES;
            pixelType = GL_UNSIGNED_INT_24_8_OES;
        }
        else
#endif
            os::Printer::log("ECF_D24S8 color format is not supported", ELL_ERROR);
        break;
    case ECF_R8:
 
Where it should be like this.

Code: Select all

             os::Printer::log("ECF_D32 color format is not supported", ELL_ERROR);
        break;
    case ECF_D24S8:
#ifdef GL_OES_packed_depth_stencil
        if (queryOpenGLFeature(COGLES1ExtensionHandler::IRR_OES_packed_depth_stencil))
        {
            internalFormat = GL_DEPTH24_STENCIL8_OES;
            pixelFormat = GL_DEPTH_STENCIL_OES;
            pixelType = GL_UNSIGNED_INT_24_8_OES;
        }
        else
#endif
            os::Printer::log("ECF_D24S8 color format is not supported", ELL_ERROR);
        break;
    case ECF_R8:
 
Have a nice day :)
CuteAlien
Admin
Posts: 9628
Joined: Mon Mar 06, 2006 2:25 pm
Location: Tübingen, Germany
Contact:

Re: GLES branch - missed a case in COGLESDriver.c

Post by CuteAlien »

Thanks for the report! Fixed now.
IRC: #irrlicht on irc.libera.chat
Code snippet repository: https://github.com/mzeilfelder/irr-playground-micha
Free racer made with Irrlicht: http://www.irrgheist.com/hcraftsource.htm
Post Reply