Page 1 of 1

[fixed] Request for a shorthand addHighLevelShader for GL

Posted: Mon Dec 12, 2011 2:22 pm
by hendu
GLSL functions are always named "main", and have no need for the DX version param. This currently means having two unneeded parameters in the addHighLevelShader call per shader type (vert, frag, geom - up to 6 unnecessary params).

It would be more elegant not to require those params - to have two (one for vert+frag, one for v+f+g) shorthand function wrappers in Irrlicht.


This is somewhat easier to work around client-side than the float* int* cast, but still this would be an improvement in the API :)

Re: Request for a shorthand addHighLevelShader for GL

Posted: Thu Dec 15, 2011 11:13 am
by hendu
Ping. I'm willing to post patches, but please give me a yea/nay :)

Re: Request for a shorthand addHighLevelShader for GL

Posted: Thu Dec 15, 2011 11:30 am
by CuteAlien
*sigh* we really need someone again in the team who cares mainly about Shaders... it does not seem like BlindSide will come back. I can say unfortunately nothing at all about it, never coded a Shader myself, so have to leave this for now to Hybrid.

Re: Request for a shorthand addHighLevelShader for GL

Posted: Thu Dec 15, 2011 1:06 pm
by hybrid
Yes, that's ok. I even have some patches for similar things. Please send in a patch for this one.

Re: Request for a shorthand addHighLevelShader for GL

Posted: Thu Dec 15, 2011 4:16 pm
by hendu

Re: Request for a shorthand addHighLevelShader for GL

Posted: Mon Jan 02, 2012 3:38 pm
by hendu
Ping as the holidays are over.