[SOLVED] problem creating IImage from .TGA files

[xirtamatrix]

hi,

I'm creating an IImage from the texture and then writing it to a file.
here's the code:

Code: Select all

IImage *image = driver->createImageFromFile(node->getMaterial(i).getTexture(0)->getName().getPath());

if (!driver->writeImageToFile(image, targetFolderName.toStdString().c_str()  ) )
{
               QMessageBox::warning(this, tr("Oops..."),
                          tr("Cannot write file %1 \n")
                         .arg(targetFolderName));
   writer->drop();
   image->drop();
   return false;
}



It works fine with .jpg and .png images but when using .TGA it seems createImageFromFile() fails to create an IImage.

Any idea why and/or what I'm doing wrong?

/regards

[hybrid]

Probably the tga file is broken or contains unsupported feated. Check the console log.

[xirtamatrix]

Probably the tga file is broken or contains unsupported feated. Check the console log.

Thanks hybrid! No the TGA is ok, I've tested this with many different TGAs and same problem, also, no output in console.

It just occured to me that maybe the problem is not with creating the IImage at all, but how do I really check that? Right now nothing comming to my head. I tried doing:

Code: Select all

IImage *image = 0;
image = driver->createImageFromFile(node->getMaterial(i).getTexture(0)->getName().getPath());
if(!image)
{
   printf("FATAL ERROR: Failed to create image!!! \n");
   return false;
}


but the printf never gets executed, humn... so which means something is getting into *image afterall... but problem is when I'm doing:

Code: Select all

if (!driver->writeImageToFile(image, targetFolderName.toStdString().c_str()  ) )

the if always gets true so meaning the image never gets written. Can't be any problem with paths because in case of .jpg and .png everything working perfectly.

weird! ( scrathing head...)

[hybrid]

Ok, that's a different thing then. So first, check if the image is correctly loaded. E.g. by exporting it into a jpg instead. And also check if a corerct tga is created. Maybe it's just the return code that is wrong. If everything works fine, I'll check the image writer code.

[xirtamatrix]

ok, did as you suggested and I can confirm the IImage is created correctly from the source TGA and it is written correctly if writing as .jpg

The problem appears when trying to write it as .tga, so... the problem lies somewhere with writeImageToFile() I suspect.

/regards

[xirtamatrix]

Ok, that's a different thing then. So first, check if the image is correctly loaded. E.g. by exporting it into a jpg instead. And also check if a corerct tga is created. Maybe it's just the return code that is wrong. If everything works fine, I'll check the image writer code.

I also checked writing a .png from the same TGA file and it also works fine and retains transparency.

So the problem really is somewhere in the TGA writer. Would much appeciate if you could take a look at it.

[CuteAlien]

Ok, thanks - it was really a bug in the writer (a wrong check for success in CImageWriterTGA::writeImage). It's fixed now in Irrlicht 1.7 release branch (r3515).

If you want to fix it locally on your Irrlicht - change in the last line in
CImageWriterTGA::writeImage the < into <=

Code: Select all

return imageHeader.ImageHeight <= y;


[xirtamatrix]

Ok, thanks - it was really a bug in the writer (a wrong check for success in CImageWriterTGA::writeImage). It's fixed now in Irrlicht 1.7 release branch (r3515).

If you want to fix it locally on your Irrlicht - change in the last line in
CImageWriterTGA::writeImage the < into <=

Code: Select all

return imageHeader.ImageHeight <= y;


wow! that was fast
Thank you very much really! I fixed it and working fine now.

/regards